adr check: enforce sign-off on decided records #661

New issue

Open

opened 2026-09-29 16:40:53 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-29 16:40:53 +00:00

Owner

What to build

The token: ADR-ACCEPT NNNN, ADR-REJECT NNNN, or ADR-DEPRECATE NNNN, for the record's status. NNNN may carry a repo prefix, such as rubric/0007; a prefix that names another repo does not match.
With two or more contributors, a decided record passes when one of its decision issues holds the token in a comment from a contributor who is not the author of the status change. This applies to old records too.
With one contributor, the rule reports NOT APPLICABLE, exits 0, and warns on every run.
The check prints one posture line on every run: ENFORCED or NOT APPLICABLE.
When the forge checks are off, the check says that it did not check the sign-off rule or the posture.

Depends on

#655, to know the author of each status change.
#656, to know who counts as a contributor.

Acceptance

Tests against the live forge API and a test repo: a token from a second contributor passes; no token fails; a token for another record fails; a token from the author fails; one contributor gives NOT APPLICABLE and exit 0.

## What to build - The token: `ADR-ACCEPT NNNN`, `ADR-REJECT NNNN`, or `ADR-DEPRECATE NNNN`, for the record's status. `NNNN` may carry a repo prefix, such as `rubric/0007`; a prefix that names another repo does not match. - With two or more contributors, a decided record passes when one of its decision issues holds the token in a comment from a contributor who is not the author of the status change. This applies to old records too. - With one contributor, the rule reports NOT APPLICABLE, exits 0, and warns on every run. - The check prints one posture line on every run: ENFORCED or NOT APPLICABLE. - When the forge checks are off, the check says that it did not check the sign-off rule or the posture. ## Depends on - #655, to know the author of each status change. - #656, to know who counts as a contributor. ## Acceptance Tests against the live forge API and a test repo: a token from a second contributor passes; no token fails; a token for another record fails; a token from the author fails; one contributor gives NOT APPLICABLE and exit 0.

hexajon added a new dependency

2026-09-29 16:41:10 +00:00

#655 adr check: find the author of a status change as the forge PR author

hexajon added a new dependency

2026-09-29 16:41:10 +00:00

#656 adr check: count contributors by access to the repo

hexajon referenced this issue

2026-09-29 19:07:43 +00:00

adr check: a decided record with no decision issue fails sign-off, except the init record #671

hexajon referenced this issue

2026-09-29 19:07:50 +00:00

adr check: later status changes and edits to a decided record need sign-off #672