adr check: a decided record with no decision issue fails sign-off, except the init record #671

New issue

Open

opened 2026-09-29 19:07:43 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-29 19:07:43 +00:00

Owner

Build the rule in ADR 0047's section "A record with no decision issue": with two or more contributors, a decided record in the none - <reason> form fails the sign-off rule, except record 0000 that adr init wrote, which the check knows by its body.

Acceptance:

Tests against the live forge API and a test repo: with two contributors, a decided record in the none form fails, and the message says that it must list an issue that holds the token.
The record that adr init writes passes. A record 0000 with any other body fails.
With one contributor, the rule reports NOT APPLICABLE, as #661 does.

Depends on #661. Decision record: ADR 0047.

Build the rule in ADR 0047's section "A record with no decision issue": with two or more contributors, a decided record in the `none - <reason>` form fails the sign-off rule, except record 0000 that `adr init` wrote, which the check knows by its body. Acceptance: - Tests against the live forge API and a test repo: with two contributors, a decided record in the none form fails, and the message says that it must list an issue that holds the token. - The record that `adr init` writes passes. A record 0000 with any other body fails. - With one contributor, the rule reports NOT APPLICABLE, as #661 does. Depends on #661. Decision record: ADR 0047.

hexajon added a new dependency

2026-09-29 19:07:53 +00:00

#661 adr check: enforce sign-off on decided records

hexajon referenced this issue

2026-09-29 19:08:36 +00:00

epic: a decided record needs a second contributor's sign-off #673

hexajon added a new dependency

2026-09-29 19:08:43 +00:00

#673 epic: a decided record needs a second contributor's sign-off

hexajon added a new dependency

2026-09-29 19:36:06 +00:00

#674 epic: run forge tests against throwaway Forgejo and Gitea servers behind a real proxy