adr check: later status changes and edits to a decided record need sign-off #672

New issue

Open

opened 2026-09-29 19:07:50 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-29 19:07:50 +00:00

Owner

Build the rules in ADR 0047's sections "A later status change" and "An edit to a decided record": how the sign-off rule treats a record that is superseded, deprecated, or edited after its decision.

Acceptance:

Tests against the live forge API and a test repo:
- A record superseded by a decided record that links back passes with no new token.
- A deprecated record passes only with ADR-DEPRECATE NNNN from a contributor who did not open the PR that set it.
- An edit to a decided record fails until the token for its current status is posted after the PR that made the edit, by a contributor who did not open that PR.
- The first decision keeps its author: a contributor who gave the first token and later superseded the record does not become its author.

Depends on #661. Decision record: ADR 0047.

Build the rules in ADR 0047's sections "A later status change" and "An edit to a decided record": how the sign-off rule treats a record that is superseded, deprecated, or edited after its decision. Acceptance: - Tests against the live forge API and a test repo: - A record superseded by a decided record that links back passes with no new token. - A deprecated record passes only with `ADR-DEPRECATE NNNN` from a contributor who did not open the PR that set it. - An edit to a decided record fails until the token for its current status is posted after the PR that made the edit, by a contributor who did not open that PR. - The first decision keeps its author: a contributor who gave the first token and later superseded the record does not become its author. Depends on #661. Decision record: ADR 0047.

hexajon added a new dependency

2026-09-29 19:07:53 +00:00

#661 adr check: enforce sign-off on decided records

hexajon referenced this issue

2026-09-29 19:08:36 +00:00

epic: a decided record needs a second contributor's sign-off #673

hexajon added a new dependency

2026-09-29 19:08:43 +00:00

#673 epic: a decided record needs a second contributor's sign-off

hexajon added a new dependency

2026-09-29 19:36:06 +00:00

#674 epic: run forge tests against throwaway Forgejo and Gitea servers behind a real proxy