sixfold-space/madtea

SHA256

Fork 0

feat: fail the gate early on lint, and run the doc tests in docs-only mode #877

Merged

hexajon merged 4 commits from gate-docs-only-doc-tests into main

2026-10-23 03:48:33 +00:00

hexajon commented

2026-10-23 03:48:31 +00:00

Owner

Summary

The gate now stops early and spends less on doc-only changes.

A docs-only diff runs hook-tests, adr-check, and the internal/docs tests, in parallel. It still builds and analyzes nothing. Before, it skipped the internal/docs tests, so a glossary or link defect passed until the next full gate.
staticcheck and modernize run in their own stage after the cheap checks and before the heavy block, in parallel. A lint finding stops the gate there with GATE: FAIL (lint), before the race tests start. A planted unused function proved this.
Two staticcheck findings in the adr service are fixed (ST1005 and U1000), and one WriteString concatenation in a test helper.

The decision is in docs/decisions/0060-docs-only-gate-runs-the-doc-checks.md, proposed.

## Summary The gate now stops early and spends less on doc-only changes. - A docs-only diff runs hook-tests, adr-check, and the internal/docs tests, in parallel. It still builds and analyzes nothing. Before, it skipped the internal/docs tests, so a glossary or link defect passed until the next full gate. - staticcheck and modernize run in their own stage after the cheap checks and before the heavy block, in parallel. A lint finding stops the gate there with `GATE: FAIL (lint)`, before the race tests start. A planted unused function proved this. - Two staticcheck findings in the adr service are fixed (ST1005 and U1000), and one WriteString concatenation in a test helper. The decision is in docs/decisions/0060-docs-only-gate-runs-the-doc-checks.md, proposed.

hexajon added 4 commits

2026-10-23 03:48:31 +00:00

fix: clear the two staticcheck findings in the adr service bd1bbd2e82

The legacy-tree error ended with a period (ST1005), and the test helper
hasProblem had no caller (U1000).

feat: run the internal/docs tests in the docs-only gate, in parallel be46d0fe97

A docs-only diff now runs hook-tests, adr-check, and the doc tests at the
same time, and still builds and analyzes nothing.

Refs #769

test: write the index row and its newline as two writes in madrReadme 9cb983cc10

feat: run staticcheck and modernize before the heavy gate block, and stop on a finding

ci / gate (pull_request) Has been cancelled

Details

drift / govulncheck (pull_request) Has been cancelled

Details

drift / surface-diff (pull_request) Has been cancelled

Details

drift / forgejo-smoke (pull_request) Has been cancelled

Details

ci / gate (push) Has been cancelled

Details

drift / govulncheck (push) Has been cancelled

Details

drift / surface-diff (push) Has been cancelled

Details

drift / forgejo-smoke (push) Has been cancelled

Details

c157c074c3

A lint finding now fails the gate in seconds, before the race tests start.

Refs #769

hexajon merged commit c157c074c3 into main

2026-10-23 03:48:33 +00:00

hexajon referenced this pull request

2026-10-23 04:38:18 +00:00

gate: docs-only mode runs the doc tests, and lint fails before the heavy block #884

hexajon referenced this pull request

2026-10-23 04:38:29 +00:00

gate: docs-only mode runs the doc tests, and lint fails before the heavy block #884

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sixfold-space/madtea!877

No description provided.

Rows
Columns