sixfold-space/madtea

SHA256

Fork 0

test: build the oversized hook-test input in bash, not python3 #865

Merged

hexajon merged 1 commit from issue-627-hook-test-drop-python3 into main

2026-10-21 17:01:33 +00:00

hexajon commented

2026-10-21 17:01:30 +00:00

Owner

Summary

What was wrong

The test hooks/tests/surface-tool-error.test.sh built its oversized error text with a python3 one-liner. The test needs this text to check that the hook cuts long errors to 500 characters.

The fallback was printf '%0.s x' {1..600}. That command prints 600 copies of " x", which is 1200 characters, not 600. The test passed with either string because both are longer than 500 characters. But the fallback did not match the code it replaced, and the test needed no Python.

What changed

In hooks/tests/surface-tool-error.test.sh, long_text now comes from printf 'x%.0s' {1..600} alone. The python3 call and the wrong fallback are gone.
I added a check that long_text is exactly 600 characters. It prints PASS [oversized input is 600 chars] or FAIL [oversized input is N chars, expected 600] and updates the pass and fail counters like the other checks in the file.

No hook code changed. Only the test file changed.

What the tests cover

The new check proves the input length is 600 characters, so the 500-character bound is tested against a known length.
The existing oversized-text check still runs on the new input.

Refs #627

./scripts/gate.sh passes on this commit.

Closes #627

## Summary ## What was wrong The test `hooks/tests/surface-tool-error.test.sh` built its oversized error text with a `python3` one-liner. The test needs this text to check that the hook cuts long errors to 500 characters. The fallback was `printf '%0.s x' {1..600}`. That command prints 600 copies of " x", which is 1200 characters, not 600. The test passed with either string because both are longer than 500 characters. But the fallback did not match the code it replaced, and the test needed no Python. ## What changed - In `hooks/tests/surface-tool-error.test.sh`, `long_text` now comes from `printf 'x%.0s' {1..600}` alone. The `python3` call and the wrong fallback are gone. - I added a check that `long_text` is exactly 600 characters. It prints `PASS [oversized input is 600 chars]` or `FAIL [oversized input is N chars, expected 600]` and updates the pass and fail counters like the other checks in the file. No hook code changed. Only the test file changed. ## What the tests cover - The new check proves the input length is 600 characters, so the 500-character bound is tested against a known length. - The existing oversized-text check still runs on the new input. Refs #627 `./scripts/gate.sh` passes on this commit. Closes #627

hexajon added 1 commit

2026-10-21 17:01:30 +00:00

test: build the oversized hook-test input in bash, not python3

drift / govulncheck (pull_request) Has been skipped

Details

drift / surface-diff (pull_request) Successful in 6m2s

Details

drift / forgejo-smoke (pull_request) Has been skipped

Details

drift / govulncheck (push) Has been skipped

Details

drift / surface-diff (push) Successful in 3m48s

Details

drift / forgejo-smoke (push) Has been skipped

Details

ci / gate (push) Failing after 35m25s

Details

ci / gate (pull_request) Failing after 55m19s

Details

b0410d60c0

The surface-tool-error test built its 600-character input with a python3
one-liner. Its printf fallback gave 1200 characters, not 600. The input
now comes from printf alone, and a new check asserts it is exactly 600
characters.

hexajon merged commit b0410d60c0 into main

2026-10-21 17:01:33 +00:00

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sixfold-space/madtea!865

No description provided.

Rows
Columns