drop the python3 one-liner from the surface-tool-error hook test #627

New issue

Closed

opened 2026-09-24 18:36:14 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-24 18:36:14 +00:00

Owner

What

hooks/tests/surface-tool-error.test.sh:158 builds a long error string with python3 -c "print('x' * 600)", and falls back to printf '%0.s x' {1..600}. The fallback is not the same string: it gives 600 copies of " x", 1200 characters. The test only needs text longer than 500 characters, so it passes either way, but the Python line is not needed.

Fix

Build the string in bash alone: long_text=$(printf 'x%.0s' {1..600}), which gives exactly 600 "x" characters.

Acceptance

The test has no python3 call and passes.

## What `hooks/tests/surface-tool-error.test.sh:158` builds a long error string with `python3 -c "print('x' * 600)"`, and falls back to `printf '%0.s x' {1..600}`. The fallback is not the same string: it gives 600 copies of " x", 1200 characters. The test only needs text longer than 500 characters, so it passes either way, but the Python line is not needed. ## Fix Build the string in bash alone: `long_text=$(printf 'x%.0s' {1..600})`, which gives exactly 600 "x" characters. ## Acceptance - The test has no `python3` call and passes.

hexajon added the

refactoring

testing

labels

2026-09-24 18:36:14 +00:00

hexajon referenced this issue

2026-09-24 18:36:41 +00:00

Epic: no Python in the repo #630

hexajon added a new dependency

2026-09-24 18:36:49 +00:00

#630 Epic: no Python in the repo

hexajon referenced this issue from a pull request that will close it,