sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 221 Pull requests Projects Releases 13 Packages Wiki Activity Actions 9

feat(guard): #653 add the guard package with its three write effects #772

Merged
hexajon merged 1 commit from issue-653-guard-package into main 2026-10-15 19:39:59 +00:00
Conversation 0 Commits 1 Files changed 3 +251 -19
hexajon commented 2026-10-15 19:39:57 +00:00
Owner
Copy link

Summary

Adds the guard package (internal/service/guard): three pure, table-testable
write-effect decisions - DefaultBranchWrite, UnrecoverableDestroy,
OutOfScopeContentWrite. Each takes no override, and every refusal names the next
step, never a way around it. The default-branch and destroy effects have no
production caller yet; that wiring is the later #670 children. The
out-of-scope content-write rule moves out of internal/mcp/forgewrite_guard.go
into the package with its behavior unchanged, and the mcp wrapper now delegates.
Per ADR 0046.

Closes #653

## Summary Adds the guard package (internal/service/guard): three pure, table-testable write-effect decisions - DefaultBranchWrite, UnrecoverableDestroy, OutOfScopeContentWrite. Each takes no override, and every refusal names the next step, never a way around it. The default-branch and destroy effects have no production caller yet; that wiring is the later #670 children. The out-of-scope content-write rule moves out of internal/mcp/forgewrite_guard.go into the package with its behavior unchanged, and the mcp wrapper now delegates. Per ADR 0046. Closes #653
feat(guard): #653 add the guard package with its three write effects
All checks were successful
drift / govulncheck (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 46s
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
ci / mcp-conformance (pull_request) Successful in 1m39s
Details
ci / mcp-conformance (push) Successful in -16s
Details
drift / govulncheck (push) Has been skipped
Details
drift / surface-diff (push) Successful in -33s
Details
drift / forgejo-smoke (push) Has been skipped
Details
ci / gate (push) Successful in 9m38s
Details
ci / gate (pull_request) Successful in 20m22s
Details
9dedee7141
 
A new internal/service/guard package decides a write by its effect: a write
to the default branch, a destroy of unrecoverable work, or a content write
outside the session scope. Each effect is a pure, table-tested function with
one refusal string and no override of any kind. The out-of-scope scope rule
moves here from internal/mcp/forgewrite_guard.go, which now supplies the
forge reader and delegates the decision. Existing callers and behavior stay
the same.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!772
No description provided.