fix(mcp): bump go-sdk to v1.8.0 so tool results carry resultType #748

Merged
hexajon merged 1 commit from issue-740-bump-go-sdk-1-8-0 into main 2026-10-09 21:14:26 +00:00
Owner

Summary

Protocol revision 2026-07-28 requires resultType on every tools/call result, and a conforming client rejects a result that omits it. madtea does not frame results itself; the go-sdk sets resultType at the session layer for new-protocol clients. v1.7.0 predated that, so some results went out without resultType and clients rejected them (seen on madt_issues search, madt_finish, madt_branch_delete). v1.8.0 emits it, so the fix is the SDK bump, not a per-handler change.

internal/mcp/result_type_test.go is an integration guard: on a 2026-07-28 session it checks that representative tool results carry resultType, and fails if the server is ever built on an SDK that stops emitting it.

Verified: full local gate green (test-race, govulncheck, gosec, osv-scanner, mcp-conformance); the resultType guard passes; the rebuilt binary reports go-sdk v1.8.0.

Closes #740

Closes #740

## Summary Protocol revision 2026-07-28 requires resultType on every tools/call result, and a conforming client rejects a result that omits it. madtea does not frame results itself; the go-sdk sets resultType at the session layer for new-protocol clients. v1.7.0 predated that, so some results went out without resultType and clients rejected them (seen on madt_issues search, madt_finish, madt_branch_delete). v1.8.0 emits it, so the fix is the SDK bump, not a per-handler change. internal/mcp/result_type_test.go is an integration guard: on a 2026-07-28 session it checks that representative tool results carry resultType, and fails if the server is ever built on an SDK that stops emitting it. Verified: full local gate green (test-race, govulncheck, gosec, osv-scanner, mcp-conformance); the resultType guard passes; the rebuilt binary reports go-sdk v1.8.0. Closes #740 Closes #740
fix(mcp): bump go-sdk to v1.8.0 so tool results carry resultType
All checks were successful
drift / surface-diff (pull_request) Successful in 55s
drift / forgejo-smoke (pull_request) Has been skipped
ci / mcp-conformance (pull_request) Successful in 1m36s
ci / mcp-conformance (push) Successful in -20s
drift / surface-diff (push) Successful in -24s
drift / govulncheck (push) Has been skipped
drift / forgejo-smoke (push) Has been skipped
ci / gate (push) Successful in 10m44s
ci / gate (pull_request) Successful in 19m5s
drift / govulncheck (pull_request) Has been skipped
78b43363d9
Closes #740
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!748
No description provided.