sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 221 Pull requests Projects Releases 13 Packages Wiki Activity Actions 9

fix(config): #715 run RequireSecureScheme in the env credential resolver #733

Merged
hexajon merged 2 commits from issue-715-cred-resolver-scheme into main 2026-10-06 18:07:57 +00:00
Conversation 0 Commits 2 Files changed 2 +41 -1
hexajon commented 2026-10-06 18:07:49 +00:00
Owner
Copy link

Summary

GetCredentialsWithSource returned the env MADTEA_URL and token without the cleartext-http guard. Every current caller re-runs the guard, so the gap is latent, but a future caller could skip it. Add RequireSecureScheme in the env-var branch, like the sibling GetCredentials branch and ADR 0041: the check belongs at the point that carries the token. An https or loopback setup is unaffected. Only a non-loopback http env URL with a token is refused.

Closes #715

## Summary GetCredentialsWithSource returned the env MADTEA_URL and token without the cleartext-http guard. Every current caller re-runs the guard, so the gap is latent, but a future caller could skip it. Add RequireSecureScheme in the env-var branch, like the sibling GetCredentials branch and ADR 0041: the check belongs at the point that carries the token. An https or loopback setup is unaffected. Only a non-loopback http env URL with a token is refused. Closes #715
fix(config): #715 run RequireSecureScheme in the env credential resolver
Some checks failed
ci / gate (pull_request) Has been cancelled
Details
ci / mcp-conformance (pull_request) Has been cancelled
Details
drift / govulncheck (pull_request) Has been cancelled
Details
drift / surface-diff (pull_request) Has been cancelled
Details
drift / forgejo-smoke (pull_request) Has been cancelled
Details
fd7e0d6c9d
 
GetCredentialsWithSource returned the env MADTEA_URL and token without the
cleartext-http guard. Every current caller re-runs the guard, so the gap is
latent. A future caller could use the result and skip the check.

Add RequireSecureScheme in the env-var branch, like the sibling GetCredentials
branch and ADR 0041: the token-security check belongs at the point that carries
the token. The function has no error channel, so a refusal gives the all-empty
not-configured result. An https or loopback setup is unaffected. Only a
non-loopback http env URL with a token is refused.
Merge branch 'main' into issue-715-cred-resolver-scheme
Some checks failed
ci / gate (push) Successful in 14m39s
Details
ci / mcp-conformance (pull_request) Successful in 1m53s
Details
drift / govulncheck (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 44s
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
ci / mcp-conformance (push) Successful in -17s
Details
drift / govulncheck (push) Has been skipped
Details
drift / surface-diff (push) Successful in -18s
Details
drift / forgejo-smoke (push) Has been skipped
Details
ci / gate (pull_request) Failing after 14m55s
Details
ca10694047
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!733
No description provided.