sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 221 Pull requests Projects Releases 13 Packages Wiki Activity Actions 9

fix(git): #710 guard tag create name and ref against a leading dash #731

Merged
hexajon merged 1 commit from issue-710-tag-dash-guard into main 2026-10-06 18:05:16 +00:00
Conversation 0 Commits 1 Files changed 2 +75 -1
hexajon commented 2026-10-06 18:05:14 +00:00
Owner
Copy link

Summary

Reject a leading-dash tag name and commit ref before they reach git tag argv, where git would read them as option flags. This mirrors the ValidateRef guard the push/fetch/branch paths already use. Two tests prove the create path refuses a --prefixed name and a --prefixed commit ref, and runs no git op.

Closes #710

## Summary Reject a leading-dash tag name and commit ref before they reach `git tag` argv, where git would read them as option flags. This mirrors the ValidateRef guard the push/fetch/branch paths already use. Two tests prove the create path refuses a `-`-prefixed name and a `-`-prefixed commit ref, and runs no git op. Closes #710
fix(git): #710 guard tag create name and ref against a leading dash
Some checks failed
ci / mcp-conformance (pull_request) Successful in 1m38s
Details
ci / mcp-conformance (push) Successful in -16s
Details
drift / govulncheck (push) Has been skipped
Details
drift / surface-diff (push) Successful in -19s
Details
drift / forgejo-smoke (push) Has been skipped
Details
ci / gate (push) Failing after 15m35s
Details
ci / gate (pull_request) Successful in 35m11s
Details
drift / govulncheck (pull_request) Has been skipped
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 39s
Details
c665828105
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!731
No description provided.