sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 220 Pull requests Projects Releases 14 Packages Wiki Activity Actions 1

fix(auth): strip userinfo from the URLs that whoami prints #612

Merged
hexajon merged 1 commit from issue-608-whoami-url-userinfo into main 2026-09-23 16:38:54 +00:00
Conversation 0 Commits 1 Files changed 4 +55 -3
hexajon commented 2026-09-23 16:38:52 +00:00
Owner
Copy link

Summary

auth whoami printed the resolved forge URL as it was, so a hand-set URL with user:secret@host put the secret into the terminal or a transcript. The new config.RedactUserinfo removes the userinfo. whoami uses it for the URL line (the text output and the JSON field) and for both resolution-chain listings.

RedactUserinfo works on the raw text, so it also cleans a URL that net/url cannot parse. A whoami test runs the real command with a secret in MADTEA_URL and fails with the redaction removed.

Closes #608

Closes #608

## Summary `auth whoami` printed the resolved forge URL as it was, so a hand-set URL with `user:secret@host` put the secret into the terminal or a transcript. The new `config.RedactUserinfo` removes the userinfo. whoami uses it for the URL line (the text output and the JSON field) and for both resolution-chain listings. `RedactUserinfo` works on the raw text, so it also cleans a URL that `net/url` cannot parse. A whoami test runs the real command with a secret in `MADTEA_URL` and fails with the redaction removed. Closes #608 Closes #608
fix(auth): strip userinfo from the URLs that whoami prints
Some checks failed
ci / mcp-conformance (pull_request) Successful in 2m9s
Details
drift / govulncheck (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 59s
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
ci / mcp-conformance (push) Successful in 1s
Details
drift / govulncheck (push) Has been skipped
Details
drift / forgejo-smoke (push) Has been skipped
Details
drift / surface-diff (push) Successful in -1s
Details
ci / gate (push) Failing after 15m3s
Details
ci / gate (pull_request) Successful in 26m42s
Details
10f6646f3e
 
Closes #608
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!612
No description provided.