sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 220 Pull requests Projects Releases 14 Packages Wiki Activity Actions 1

fix(config): refuse a token over non-loopback http on every config request #606

Merged
hexajon merged 2 commits from fix/scheme-check-authed-request into main 2026-09-23 15:28:29 +00:00
Conversation 0 Commits 2 Files changed 5 +160 -1
hexajon commented 2026-09-23 15:28:27 +00:00
Owner
Copy link

Summary

doAuthedRequest now runs RequireSecureScheme before it attaches the token, so every token-bearing request in internal/config refuses a non-loopback http:// URL. The environment rung of GetCredentialsWithSource skipped the check, so auth whoami sent an env token over cleartext. Token-less requests, https, and loopback http still go out. A test proves the refusal comes before any request is sent, and it fails with the guard removed.

The refusal text named gitea.url, a key madtea does not read. It now names MADTEA_URL and madtea.url.

ADR 0041 records the rule: no token over non-loopback http, no opt-out, loopback exempt.

Closes #605

Closes #605

## Summary `doAuthedRequest` now runs `RequireSecureScheme` before it attaches the token, so every token-bearing request in `internal/config` refuses a non-loopback `http://` URL. The environment rung of `GetCredentialsWithSource` skipped the check, so `auth whoami` sent an env token over cleartext. Token-less requests, `https`, and loopback `http` still go out. A test proves the refusal comes before any request is sent, and it fails with the guard removed. The refusal text named `gitea.url`, a key madtea does not read. It now names `MADTEA_URL` and `madtea.url`. ADR 0041 records the rule: no token over non-loopback http, no opt-out, loopback exempt. Closes #605 Closes #605 
doAuthedRequest now runs RequireSecureScheme before it attaches the token.
The env rung of GetCredentialsWithSource skipped that check, so auth whoami
sent an env token to a non-loopback http URL.

The refusal also named gitea.url, a key madtea does not read. It now names
MADTEA_URL and madtea.url.
fix(config): refuse a token over non-loopback http on every config request
All checks were successful
ci / mcp-conformance (pull_request) Successful in 1m57s
Details
drift / govulncheck (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 1m14s
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
ci / mcp-conformance (push) Successful in 2s
Details
drift / govulncheck (push) Has been skipped
Details
drift / surface-diff (push) Successful in -4s
Details
drift / forgejo-smoke (push) Has been skipped
Details
ci / gate (push) Successful in 17m12s
Details
ci / gate (pull_request) Successful in 30m19s
Details
0dab4ac758
 
Closes #605
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!606
No description provided.