sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 220 Pull requests Projects Releases 14 Packages Wiki Activity Actions 1

fix(config): key credentials by the forge host alone, per ADR 0025 #604

Merged
hexajon merged 1 commit from fix/forgehost-host-only into main 2026-09-23 15:20:17 +00:00
Conversation 0 Commits 1 Files changed 2 +12 -14
hexajon commented 2026-09-23 15:20:14 +00:00
Owner
Copy link

Summary

ADR 0025 keys credentials by the forge host alone. forgeHost kept the URL path, so a forge under a sub-path (https://example.com/gitea) was keyed example.com/gitea. forgeHost now returns host[:port] only. The API URL itself keeps its path; only the credential key and the host comparisons change.

Behavior change: a user whose madtea.url has a sub-path must run madtea auth login once after the upgrade, because the stored key no longer matches. Sub-path forges on one host now share one credential. They already share one browser origin, which the Forgejo reverse-proxy docs warn about.

Side effect: the whoami origin mismatch check no longer reports a false mismatch between a sub-path madtea.url and its origin host.

## Summary ADR 0025 keys credentials by the forge host alone. `forgeHost` kept the URL path, so a forge under a sub-path (`https://example.com/gitea`) was keyed `example.com/gitea`. `forgeHost` now returns `host[:port]` only. The API URL itself keeps its path; only the credential key and the host comparisons change. Behavior change: a user whose `madtea.url` has a sub-path must run `madtea auth login` once after the upgrade, because the stored key no longer matches. Sub-path forges on one host now share one credential. They already share one browser origin, which the Forgejo reverse-proxy docs warn about. Side effect: the `whoami` origin mismatch check no longer reports a false mismatch between a sub-path `madtea.url` and its origin host.
fix(config): key credentials by the forge host alone, per ADR 0025
All checks were successful
drift / govulncheck (pull_request) Has been skipped
Details
drift / surface-diff (pull_request) Successful in 1m3s
Details
drift / forgejo-smoke (pull_request) Has been skipped
Details
ci / mcp-conformance (pull_request) Successful in 1m57s
Details
ci / mcp-conformance (push) Successful in 0s
Details
drift / govulncheck (push) Has been skipped
Details
drift / surface-diff (push) Successful in 1s
Details
drift / forgejo-smoke (push) Has been skipped
Details
ci / gate (push) Successful in 13m44s
Details
ci / gate (pull_request) Successful in 25m48s
Details
d870ef9c74
 
forgeHost kept the URL path, so a forge under a sub-path
(https://example.com/gitea) was keyed example.com/gitea. ADR 0025 keys
credentials by the forge host alone. forgeHost now returns host[:port] only.

A user with a sub-path madtea.url must run madtea auth login once after the
upgrade, because the old key no longer matches.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!604
No description provided.