fix(test): stop a config test writing into the source tree #603

Merged

hexajon merged 1 commit from fix/test-writes-into-source-tree into main

2026-09-23 14:57:45 +00:00

hexajon commented

2026-09-23 14:57:43 +00:00

Owner

Summary

The intermittent internal/gitexec failure in the gate had a real cause. TestGetCredentialsWithSource_AmbientDegradesToNotConfigured made and then removed a directory under internal/config. The gitexec contract test walks internal/ in the same parallel go test ./..., and a directory removed mid-walk failed that walk. I found the writer with scripts/watch-tree-writes.py, a new script that logs files that appear or vanish under internal/ and cmd/ during a run. After this change, a full gate run logs no writes into the tree.

The test now keeps its config in a real temp directory and moves TMPDIR to a sibling, so the guard still sees the config as outside temp. It also runs outside any git repo. Before, the origin rung and host corroboration blocked the token even with the guard call removed, so the test never proved the guard. With that call removed, the test now fails.

The gate now keeps a failed leg's full log and prints its FAIL lines with context. Before, it showed only the last 25 lines and deleted the log, which hid this failure.

## Summary The intermittent `internal/gitexec` failure in the gate had a real cause. `TestGetCredentialsWithSource_AmbientDegradesToNotConfigured` made and then removed a directory under `internal/config`. The gitexec contract test walks `internal/` in the same parallel `go test ./...`, and a directory removed mid-walk failed that walk. I found the writer with `scripts/watch-tree-writes.py`, a new script that logs files that appear or vanish under `internal/` and `cmd/` during a run. After this change, a full gate run logs no writes into the tree. The test now keeps its config in a real temp directory and moves `TMPDIR` to a sibling, so the guard still sees the config as outside temp. It also runs outside any git repo. Before, the origin rung and host corroboration blocked the token even with the guard call removed, so the test never proved the guard. With that call removed, the test now fails. The gate now keeps a failed leg's full log and prints its FAIL lines with context. Before, it showed only the last 25 lines and deleted the log, which hid this failure.

hexajon added 1 commit

2026-09-23 14:57:43 +00:00

fix(test): stop a config test writing into the source tree

drift / govulncheck (pull_request) Has been skipped

Details

drift / surface-diff (pull_request) Successful in 1m9s

Details

drift / forgejo-smoke (pull_request) Has been skipped

Details

ci / mcp-conformance (pull_request) Successful in 4m16s

Details

ci / mcp-conformance (push) Successful in 1m49s

Details

drift / govulncheck (push) Has been skipped

Details

drift / surface-diff (push) Successful in -7s

Details

drift / forgejo-smoke (push) Has been skipped

Details

ci / gate (push) Successful in 12m29s

Details

ci / gate (pull_request) Successful in 18m57s

Details

5e144e8a43

TestGetCredentialsWithSource_AmbientDegradesToNotConfigured made and then
removed a directory under internal/config. The gitexec contract test walks
internal/ during the same parallel go test ./..., and a directory removed
mid-walk failed that walk. This was the intermittent gitexec failure in the
gate.

The test now keeps its config in a real temp directory and moves TMPDIR to
a sibling, so the guard still sees the config as outside temp. It also runs
outside any git repo. Before, the origin rung and host corroboration blocked
the token even with the guard removed, so the test never proved the guard.
With the guard removed it now fails.

The gate now keeps a failed leg's full log and prints its FAIL lines with
context. Before, it showed the last 25 lines and deleted the log, which hid
this failure. scripts/watch-tree-writes.py logs files that appear or vanish
under internal/ and cmd/ during a run.

hexajon merged commit 5e144e8a43 into main

2026-09-23 14:57:45 +00:00

hexajon referenced this pull request

2026-09-24 18:36:22 +00:00

port watch-tree-writes.py to a madtea-dev subcommand #628