feat(prs)!: remove force_merge/--admin, madtea never overrides required CI checks #481
No reviewers
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea!481
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-480-remove-force-merge"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
madt_prs action=merge and madtea pr merge no longer accept a force-past-checks override. The force_merge arg and the --admin flag are gone, with MergePROptions.ForceMerge and the force_merge merge-payload key.
A merge never bypasses the target repo's required status checks. The green gate is authoritative. A check-gated merge still waits for green via auto_merge (#438, #464). A normal merge is unchanged.
TestMergePRData_NeverForceMerge locks the guarantee: no merge payload may carry a force or admin override key.
BREAKING CHANGE: removes the public pr merge --admin flag and the madt_prs force_merge arg.
Closes #480