chore(hooks): remove the dead binary hook-install channel residue #451

Merged
hexajon merged 1 commit from chore/remove-dead-hooks-embed into main 2026-08-25 19:42:51 +00:00
Owner

Summary

The binary no longer materializes the agent-safety hook scripts. The Claude Code plugin is the single delivery channel (docs/safety/safety-hooks.md, internal/cmd/install/mcp.go). hooks/embed.go was left behind from the retired binary channel: nothing imports the package, and its comment still described the removed mcp-config --install materialize path as live, which was misleading.

Remove the dead file and the stale references to it:

  • Delete hooks/embed.go (orphaned go:embed, no importer).
  • assemble-plugin-artifact.test.sh: drop the embed.go-specific artifact check; the general no-*.go guard already covers it.
  • assemble-plugin-artifact.sh and lib-hook-harness.sh: drop the embed.go mentions in comments.

The live plugin hooks (hooks/hooks.json + hooks/scripts/*.sh) are unchanged. Full gate green.

## Summary The binary no longer materializes the agent-safety hook scripts. The Claude Code plugin is the single delivery channel (docs/safety/safety-hooks.md, internal/cmd/install/mcp.go). `hooks/embed.go` was left behind from the retired binary channel: nothing imports the package, and its comment still described the removed `mcp-config --install` materialize path as live, which was misleading. Remove the dead file and the stale references to it: - Delete `hooks/embed.go` (orphaned `go:embed`, no importer). - `assemble-plugin-artifact.test.sh`: drop the `embed.go`-specific artifact check; the general no-`*.go` guard already covers it. - `assemble-plugin-artifact.sh` and `lib-hook-harness.sh`: drop the `embed.go` mentions in comments. The live plugin hooks (`hooks/hooks.json` + `hooks/scripts/*.sh`) are unchanged. Full gate green.
chore(hooks): remove the dead binary hook-install channel residue
All checks were successful
drift / govulncheck (pull_request) Has been skipped
drift / surface-diff (pull_request) Successful in 1m2s
drift / forgejo-smoke (pull_request) Has been skipped
ci / mcp-conformance (pull_request) Successful in 2m0s
drift / govulncheck (push) Has been skipped
drift / surface-diff (push) Successful in -1s
ci / mcp-conformance (push) Successful in 4s
drift / forgejo-smoke (push) Has been skipped
ci / gate (push) Successful in 20m23s
ci / gate (pull_request) Successful in 22m5s
e612172642
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!451
No description provided.