sixfold-space/madtea
sixfold-space/madtea
SHA256
2
0
Fork 0
Code Issues 33 Pull requests Projects Releases 11 Packages Wiki Activity Actions

fix(release): make release.sh survive tag.gpgsign and a missing forge release #104

Merged
hexajon merged 1 commit from refs/pull/104/head into main 2026-07-15 16:05:21 +00:00
Conversation 0 Commits 1 Files changed 1 +10 -2
hexajon commented 2026-07-15 16:05:12 +00:00 (Migrated from codeberg.org)
Copy link

Summary

Two release.sh bugs stranded v0.15.1 half-cut (tag pushed, no release):

  1. forge_release_exists checked madtea api's exit code, but the api passthrough exits 0 even on HTTP 404 (error JSON on stdout) — so the check was always-true and goreleaser was skipped for a release that didn't exist. Switched to madtea release get, which exits nonzero when the release is missing (verified: missing→1, existing→0).

  2. git tag "$tag" (lightweight) dies non-interactively with fatal: no tag message? under the repo-local tag.gpgsign=true added after v0.15.0, because signing forces an annotated tag that demands a message. Now creates the tag with -m "$tag".

The madtea api exit-0-on-HTTP-error behavior itself is a CLI bug (gh api exits 1); filed separately.

## Summary Two release.sh bugs stranded v0.15.1 half-cut (tag pushed, no release): 1. `forge_release_exists` checked `madtea api`'s exit code, but the api passthrough exits 0 even on HTTP 404 (error JSON on stdout) — so the check was always-true and goreleaser was skipped for a release that didn't exist. Switched to `madtea release get`, which exits nonzero when the release is missing (verified: missing→1, existing→0). 2. `git tag "$tag"` (lightweight) dies non-interactively with `fatal: no tag message?` under the repo-local `tag.gpgsign=true` added after v0.15.0, because signing forces an annotated tag that demands a message. Now creates the tag with `-m "$tag"`. The `madtea api` exit-0-on-HTTP-error behavior itself is a CLI bug (gh api exits 1); filed separately.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking
Breaking change - flag for release notes

  
bug
Something is not working

  
documentation
Documentation only

  
enhancement
New feature

  
epic
Tracking epic with dependency children

  
good first issue
Interested in contributing? Get started here.

  
help wanted
Maintainer would welcome outside help

  
refactoring
Code restructuring without behavior changes

  
resolution/duplicate
Closed as duplicate of another issue

  
resolution/invalid
Closed as invalid or not reproducible

  
resolution/wontfix
Closed as won't fix

  
security
Security issue or hardening

  
severity/critical
Security severity: critical

  
severity/high
Security severity: high

  
severity/low
Security severity: low

  
severity/medium
Security severity: medium

  
status/abandoned
Someone started, then walked away - up for grabs

  
status/blocked
Blocked by another issue or an external dependency

  
status/needs-decision
Waiting on a maintainer decision; workable once decided

  
status/needs-info
Waiting on reporter / more information before work can start

  
status/needs-verification
Done except verification in a live interactive session

  
testing
Test suite / CI infrastructure work

  
upstream
Related to an upstream repository, already reported there

No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea!104
No description provided.