refactor: give internal/gitexec the run and output disposition, collapse the five git helpers #808

New issue

Open

opened 2026-10-19 18:26:20 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-19 18:26:20 +00:00

Owner

Implements the design accepted in ADR 0056 (0056-one-git-runner-owns-output-disposition).

internal/gitexec gains one run entry that owns output disposition, with an explicit mode per stream: Capture (buffer and return), Stream (to the terminal), Tee (both). The five run helpers in internal/git (RunGitAuthDirWithStderr, RunGitAuthDirCaptureStderr, RunGitAuthDirCaptureStderrOnly, RunGitAuthDirWithCredentials, RunGitDirWithStderr) become thin wrappers that pass a disposition and keep only their credential, SSH, or plain concern.

Acceptance:

internal/gitexec owns the run and the per-stream disposition; the five helpers no longer wire stdout and stderr themselves;
Capture is the default and returns the same bytes as today, so every existing parse (Fast-forward, new branches, no tracking) is unchanged;
the CLI pull, fetch, and clone pass Tee for stderr, so git native progress reaches the terminal, while stdout stays captured for the parse;
the MCP surface passes Capture for both streams and stays quiet;
a parity test fails the build when a production file outside internal/gitexec constructs or runs a git process;
the gate is green.

Refs ADR 0056. Decision recorded in #806.

Implements the design accepted in ADR 0056 (0056-one-git-runner-owns-output-disposition). internal/gitexec gains one run entry that owns output disposition, with an explicit mode per stream: Capture (buffer and return), Stream (to the terminal), Tee (both). The five run helpers in internal/git (RunGitAuthDirWithStderr, RunGitAuthDirCaptureStderr, RunGitAuthDirCaptureStderrOnly, RunGitAuthDirWithCredentials, RunGitDirWithStderr) become thin wrappers that pass a disposition and keep only their credential, SSH, or plain concern. Acceptance: - internal/gitexec owns the run and the per-stream disposition; the five helpers no longer wire stdout and stderr themselves; - Capture is the default and returns the same bytes as today, so every existing parse (Fast-forward, new branches, no tracking) is unchanged; - the CLI pull, fetch, and clone pass Tee for stderr, so git native progress reaches the terminal, while stdout stays captured for the parse; - the MCP surface passes Capture for both streams and stays quiet; - a parity test fails the build when a production file outside internal/gitexec constructs or runs a git process; - the gate is green. Refs ADR 0056. Decision recorded in #806.

hexajon referenced this issue

2026-10-19 18:26:39 +00:00

refactor: one git-run chokepoint owns output disposition #806

hexajon referenced this issue

2026-10-19 18:41:19 +00:00

docs: accept ADR 0056 (one git-run chokepoint owns output disposition) #810

hexajon referenced this issue

2026-10-20 03:29:52 +00:00

audit: find every concern with more than one implementation, and every bypass of an existing chokepoint #834