The madt_* tools reject the first natural call too often; the first reach should succeed #747
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#747
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
madt_*tools reject the obvious first invocation far too often, so a task that should be one call becomes three or four. The schema and the help text are meant to steer the first reach so it lands; when they do not, the tool should accept the obvious synonym or do the obvious thing rather than emit a correction and make the caller try again.Cases I keep hitting:
action=runsaccepts neitherbranchnorref(ref is reported as "consumed by dispatch"), so there is no way to filter runs to one branch on the first try.update+state=closed+commentattempt is rejected for the arg name,updateturns out not to be an accepted action at all,closerefuses a comment field,commentthen needsbody, and finallyclose. "Close with a comment" should be a single call.finishrejectsmessage=(it wantstitle/summary); andfinish files=... branch=<other-repo>refuses with "use commit then finish", two calls for what reads as one.branchvsrefvsname,commentvscontent,messagevssummary. The same concept should take the same name everywhere, and the obvious synonym should be accepted.The principle: the first command a caller reaches for should succeed, because the schema and help already pointed them at the right shape. Where it cannot, accept the synonym and do the obvious thing instead of returning a help error.
Ask: audit the tool surface for first-call success - unify argument names across tools, accept common synonyms, let the list actions take the obvious filters (a branch/ref on
runs), and collapse the frequent multi-call sequences (close-with-comment, commit-then-finish) into one.