feat!: finish takes no close inputs, and every merge closes its branch issue #889

Merged

hexajon merged 27 commits from issue-879-finish-no-close-inputs into main

2026-10-23 21:22:03 +00:00

hexajon commented

2026-10-23 21:21:59 +00:00

Owner

Summary

finish no longer takes no_close, close_linked, closes=, or --close. A merge through madtea now always closes the issue that its branch names, as ADR 0061 rules.

finish refuses before any push, PR, or merge when the branch names no issue, names two, names a missing, closed, or PR number, or the issue has an open dependency, and when the forge cannot be read.
Every PR merge (finish, madt_prs merge, orchestrate, and the raw API merge call) goes through one guard limit that runs the same checks and adds a missing Closes #N line before the merge.
A revert opens its own issue, and its merge closes it.
Every first push into an empty repo asks a person, through MCP elicitation or a terminal prompt, and refuses when no person can be asked.
The dependency list is read across every page, and a repo with dependencies turned off counts as having none.
ADR 0061 is accepted, and ADR 0006, 0007, 0046, and 0058 point at its rules.

The rulings added to ADR 0061 in its last edit (origin host check, seeded repo creates, the unreadable-forge push rule, revert retry reuse, and suggestions as text only) are not built in this change. They are tracked in their own issue.

Closes #879

## Summary finish no longer takes `no_close`, `close_linked`, `closes=`, or `--close`. A merge through madtea now always closes the issue that its branch names, as ADR 0061 rules. - `finish` refuses before any push, PR, or merge when the branch names no issue, names two, names a missing, closed, or PR number, or the issue has an open dependency, and when the forge cannot be read. - Every PR merge (`finish`, `madt_prs` merge, `orchestrate`, and the raw API merge call) goes through one guard limit that runs the same checks and adds a missing `Closes #N` line before the merge. - A revert opens its own issue, and its merge closes it. - Every first push into an empty repo asks a person, through MCP elicitation or a terminal prompt, and refuses when no person can be asked. - The dependency list is read across every page, and a repo with dependencies turned off counts as having none. - ADR 0061 is accepted, and ADR 0006, 0007, 0046, and 0058 point at its rules. The rulings added to ADR 0061 in its last edit (origin host check, seeded repo creates, the unreadable-forge push rule, revert retry reuse, and suggestions as text only) are not built in this change. They are tracked in their own issue. Closes #879

hexajon added 27 commits

2026-10-23 21:21:59 +00:00

test: add failing finish pre-check tests for the no-close-inputs rule 69e3bfc240

Red step only: precheckFinishIssues and FinishIssueReader do not exist yet.
Refs #879

docs: accept the finish close-inputs record, with its record issue as the decision issue 32747438f9

docs: rule the five open points of the finish close-inputs record 7ba7e435fb

docs: point the multi-repo and close-word records at the finish close rule 2877308b3d

feat!: finish takes no close inputs and refuses before the forge when its issue cannot close 5c490731e7

docs: rule the resumed-PR close line and the empty-repo first push for finish cac2ad7ddc

docs: extend the close rule to every merge path as one guard limit 56155b7393

docs: state the one-issue branch rule in the contributor notes cc77380904

fix: read every page of an issue's dependency list so an open dependency past page 1 refuses 67af3a1315

feat!: every PR merge through madtea closes its branch issue, checked at the merge send seam 32766cafdc

The merge-close rule is one effect of the write guard. It runs before
POST /repos/{owner}/{repo}/pulls/{index}/merge, so finish, prs merge, the
orchestrate batch merge, and the raw API passthrough all pass it. It reads the
PR head branch, runs the issue pre-checks, and adds a missing close line with
the body append operation before the merge. finish keeps its early pre-check
and now calls the same rule.

feat!: a revert opens its own issue and its merge closes it 2a800a8fdd

The orchestrate auto-revert and prs revert first open an issue titled
"Revert PR #N: <reason>", name the branch issue-M-revert-pr-N, and write
Closes #M in the revert PR body. A revert branch has no exemption from the
merge-close rule.

feat!: finish makes a first push into an empty repo only after a person answers yes f0fd1f42db

In a repo with no commits, finish asks a person whether this is a new repo:
through an MCP input request (elicitation), or a prompt on a CLI terminal. A
no refuses. With no way to ask a person it refuses and names madtea init. A
forge repo with commits, or a forge repo that cannot be read, refuses before
the question. Both first-push shortcuts ask.

docs: describe the close rule for every merge and drop the stale close-input advice 66416f92ff

test: cover every finish close-rule confirmation item on the throwaway forges 95de283b3a

The forge-tagged binary now installs the production write guard, as the
madtea binary does at startup. The close-rule test covers the branch, issue,
and PR-number refusals, a resumed PR, prs merge and raw API merge, and the
empty-repo question on both forges at both pins.

docs: a person picks owner, name, and visibility when finish creates the forge repo aa2a1810e7

docs: every first push into an empty repo needs a person's yes cb9667112f

docs: bind each MCP first-push answer to a question that madtea asked 8c4e2c7117

docs: MCP init shows the agent's values as suggestions that a person confirms 9954db6238

docs: rule origin, request-state use, CLI proof, API first writes, revert retries, and dependencies off 469fe913de

feat: read the dependency setting on a 404, and refuse an unknown state or a hidden dependency 977636cb73

feat!: a forge content write into an empty repo refuses and names madtea init e6c2355903

feat: a revert retry reuses its open revert issue, and a later failure names that issue d809cf83fe

feat!: every first push asks a person, with MCP answers bound to single-use request states, and finish creates a missing forge repo d1f2d7f790

test: cover orchestrate merges and reverts, raw API close lines, the bootstrap push, init, and the finish repo create on the throwaway forges 91875cc344

docs: describe the person's yes for every first push, the init questions, and the empty-repo forge write refusal b026523dca

docs: rule the round-three open points of the first-push and revert rules bbb5df00ef