init stages every file with git add -A, against the declared-files rule #887
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#887
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
madtea initstages every file in the folder withgit add -Abefore its first commit (internal/service/workflow/init.go, the "Stage files" step). That breaks the declared-files rule of ADR 0024: a commit holds only the paths that the caller names, and madtea has no blanket staging mode.A folder with a build artifact, a secret, or a large binary next to the code puts all of it into the first commit, and that commit goes straight to the default branch with no PR.
Acceptance criteria
initstages only the paths the caller names, as ADR 0024 requires.