init stages every file with git add -A, against the declared-files rule #887

Open
opened 2026-10-23 19:24:31 +00:00 by hexajon · 0 comments
Owner

madtea init stages every file in the folder with git add -A before its first commit (internal/service/workflow/init.go, the "Stage files" step). That breaks the declared-files rule of ADR 0024: a commit holds only the paths that the caller names, and madtea has no blanket staging mode.

A folder with a build artifact, a secret, or a large binary next to the code puts all of it into the first commit, and that commit goes straight to the default branch with no PR.

Acceptance criteria

  • init stages only the paths the caller names, as ADR 0024 requires.
  • A test proves that an unnamed file in the folder is not in the first commit.
`madtea init` stages every file in the folder with `git add -A` before its first commit (`internal/service/workflow/init.go`, the "Stage files" step). That breaks the declared-files rule of ADR 0024: a commit holds only the paths that the caller names, and madtea has no blanket staging mode. A folder with a build artifact, a secret, or a large binary next to the code puts all of it into the first commit, and that commit goes straight to the default branch with no PR. ## Acceptance criteria - `init` stages only the paths the caller names, as ADR 0024 requires. - A test proves that an unnamed file in the folder is not in the first commit.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea#887
No description provided.