fix(repos): avatar_upload and get do not show the avatar, topics, or website #875
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#875
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The gap
I set a repo avatar with
madt_repos action=avatar_upload. The result was onlyUploaded repository avatar. It does not say what the forge now holds. ADR 0003 asks a side-effecting command to confirm what it did, and this confirmation leaves out the result.To confirm the upload, I ran
madt_repos action=get. The formatted text has no avatar. It also has no topics and no website, though I had just set the topics. Theraw_jsonparameter says: "The formatted text shows the full content ... use raw_json only when you need machine-readable fields". For these three fields, that is not true.So the only proof came from
madt_api_callwith a jq filter on.avatar_url, or from the whole repo object withraw_json=true. ADR 0015 keepsmadt_api_callas an escape hatch only, not the path for a routine check.What is missing
avatar_uploadreads the repo back after the upload and reports the avatar URL that the forge now holds.madt_repos action=gettext shows the repo avatar (its URL, or that none is set), the topics, and the website.Both are changes to human-readable text, which ADR 0028 keeps out of the public API, so neither is a breaking change. The
raw_jsonshape stays as it is.Acceptance criteria
madt_repos action=avatar_uploadreports theavatar_urlthat a read-back of the repo returns after the upload.madt_repos action=gettext includes the avatar URL or "no avatar", the topic list, and the website or "no website".internal/parity/.