fix(init): the existing-repo error points at "finish", which also refuses this case #842
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#842
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
I run
madtea initin a local repo that already has commits but no remote. The error is:directory already has commits - use 'madtea finish' to complete work. That remedy does not fit.finishcompletes a feature branch into a remote that already exists, and under ADR 0006finishrefuses the default branch of a non-empty repo. So the pointed-at command refuses this case too. The caller is sent in a circle.Why it matters
The real path to make an existing-history repo remote is to create the remote repo, wire
origin, and push. The error names none of that.Fix
Make the existing-repo error name the real next step: create the remote and push the existing history. The message should state a path that actually attaches a remote to existing history, and it should not point at
finish, which refuses this case.Acceptance criteria
madtea initin a non-empty repo with no remote no longer namesfinishas the remedy.Related
madt_initdiscoverability, closed), and the companion request to support gh'srepo create --sourceflags.