blocks_add skips the cycle check that deps_add runs #822

New issue

Closed

opened 2026-10-20 01:19:49 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-20 01:19:49 +00:00

Owner

deps_add refuses an edge that would close a dependency cycle: it checks the new edge against the whole existing graph. blocks_add sends the edge straight to the forge with no check.

The forge refuses only a cycle of two issues. A cycle of three or more is accepted, through both the dependencies and the blocks endpoint. The close-semantics probe in internal/testforge/closeprobe shows this on Forgejo and Gitea, at the baseline and latest pins. So blocks_add can build a ring such as A -> B -> C -> A, and none of those issues can ever close.

Fix: blocks_add runs the same cycle check as deps_add before it writes the edge, and refuses with the same message that names the cycle path.

Acceptance, against throwaway Forgejo and Gitea servers:

blocks_add that would close a ring of three issues is refused before any write, and the message names the ring.
blocks_add that closes no cycle still writes the edge.

`deps_add` refuses an edge that would close a dependency cycle: it checks the new edge against the whole existing graph. `blocks_add` sends the edge straight to the forge with no check. The forge refuses only a cycle of two issues. A cycle of three or more is accepted, through both the dependencies and the blocks endpoint. The close-semantics probe in `internal/testforge/closeprobe` shows this on Forgejo and Gitea, at the baseline and latest pins. So `blocks_add` can build a ring such as A -> B -> C -> A, and none of those issues can ever close. Fix: `blocks_add` runs the same cycle check as `deps_add` before it writes the edge, and refuses with the same message that names the cycle path. Acceptance, against throwaway Forgejo and Gitea servers: - `blocks_add` that would close a ring of three issues is refused before any write, and the message names the ring. - `blocks_add` that closes no cycle still writes the edge.

hexajon referenced this issue from a pull request that will close it,

2026-10-20 17:18:35 +00:00

fix: run the dependency cycle check before blocks_add writes an edge #848

hexajon closed this issue

2026-10-20 17:18:38 +00:00