delete-tagging completeness test misses service subpackages #787

New issue

Closed

opened 2026-10-16 01:01:05 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-16 01:01:05 +00:00

Owner

The completeness test that checks every delete call carries its guard tag scans only the top-level service package and the client.Delete* call shape. A delete in a service subpackage, for example the finish remote-branch cleanup, is tagged correctly today but is not covered by the test. A future untag there would silently refuse that cleanup with no test failure.

Fix:

Scan every service subpackage, not only the top level.
Record the residual gap for a destroy that does not start with Delete.

Acceptance:

The test covers delete call sites in service subpackages.

Part of the write-guard work (#670).

The completeness test that checks every delete call carries its guard tag scans only the top-level service package and the `client.Delete*` call shape. A delete in a service subpackage, for example the finish remote-branch cleanup, is tagged correctly today but is not covered by the test. A future untag there would silently refuse that cleanup with no test failure. Fix: - Scan every service subpackage, not only the top level. - Record the residual gap for a destroy that does not start with `Delete`. Acceptance: - The test covers delete call sites in service subpackages. Part of the write-guard work (#670).

hexajon added a new dependency

2026-10-16 01:01:43 +00:00

#670 epic: one guard enforces the recorded limits on every surface

hexajon referenced this issue from a pull request that will close it,

2026-10-16 02:41:35 +00:00

feat(guard): enforce the ADR 0046 write guard on every forge write surface #790

hexajon referenced this issue from a commit

2026-10-16 02:41:35 +00:00

test(guard): #787 broaden the delete-tagging completeness test to every subpackage

hexajon closed this issue

2026-10-16 02:41:46 +00:00