lint: split ENV_PAIRS into an array in the hook harness #765

New issue

Open

opened 2026-10-14 19:14:35 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-14 19:14:35 +00:00

Owner

What

hooks/tests/lib-hook-harness.sh:616 and :621 disable SC2086 inline. gate_exec runs env $env_pairs bash "$gate", and the unquoted $env_pairs is word-split on purpose into NAME=VALUE arguments.

How

Inside gate_exec, split the string into an array once with read -ra, then run env "${pairs[@]}" bash "$gate". The callers keep passing one string.

Acceptance

No SC2086 disable remains in the harness.
Every hook test passes.

## What `hooks/tests/lib-hook-harness.sh:616` and `:621` disable SC2086 inline. `gate_exec` runs `env $env_pairs bash "$gate"`, and the unquoted `$env_pairs` is word-split on purpose into `NAME=VALUE` arguments. ## How Inside `gate_exec`, split the string into an array once with `read -ra`, then run `env "${pairs[@]}" bash "$gate"`. The callers keep passing one string. ## Acceptance - No SC2086 disable remains in the harness. - Every hook test passes.

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#766 epic: shellcheck passes on every shell script, with no inline disables

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#761 gate: lint every shell script with shellcheck, and fail when shellcheck is missing