lint: remove the SC2016 disables from the hook tests #764

New issue

Open

opened 2026-10-14 19:14:18 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-14 19:14:18 +00:00

Owner

What

Six jq filters in the hook tests carry an inline SC2016 disable, because the filters use jq variables such as $p inside single quotes. Three are in hooks/tests/check-foreign-primary.test.sh (lines 116, 136, 330), and three are in hooks/tests/surface-tool-error.test.sh (lines 41, 111, 159).

Acceptance

No SC2016 disable remains in either file.
shellcheck passes on both files, and every hook test still passes.

## What Six jq filters in the hook tests carry an inline SC2016 disable, because the filters use jq variables such as `$p` inside single quotes. Three are in `hooks/tests/check-foreign-primary.test.sh` (lines 116, 136, 330), and three are in `hooks/tests/surface-tool-error.test.sh` (lines 41, 111, 159). ## Acceptance - No SC2016 disable remains in either file. - shellcheck passes on both files, and every hook test still passes.

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#766 epic: shellcheck passes on every shell script, with no inline disables

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#761 gate: lint every shell script with shellcheck, and fail when shellcheck is missing