lint: remove the SC2317 disables from gate.sh and mcp-conformance.sh #763

New issue

Open

opened 2026-10-14 19:14:11 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-14 19:14:11 +00:00

Owner

What

Seven functions carry an inline SC2317 disable ("command appears to be unreachable"), because the scripts call them indirectly. Six are in scripts/gate.sh (lines 143, 161, 184, 196, 215, 332), called through step and launch. One is at scripts/mcp-conformance.sh:144, called through trap. CONTRIBUTING.md:319 says that linters flag real issues and that I fix the code.

Acceptance

No SC2317 disable remains in either script.
shellcheck passes on both scripts.

## What Seven functions carry an inline SC2317 disable ("command appears to be unreachable"), because the scripts call them indirectly. Six are in `scripts/gate.sh` (lines 143, 161, 184, 196, 215, 332), called through `step` and `launch`. One is at `scripts/mcp-conformance.sh:144`, called through `trap`. `CONTRIBUTING.md:319` says that linters flag real issues and that I fix the code. ## Acceptance - No SC2317 disable remains in either script. - shellcheck passes on both scripts.

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#766 epic: shellcheck passes on every shell script, with no inline disables

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#761 gate: lint every shell script with shellcheck, and fail when shellcheck is missing