lint: remove the SC1091 disables from the shell scripts #762

New issue

Open

opened 2026-10-14 19:13:33 +00:00 by hexajon · 0 comments

hexajon commented

2026-10-14 19:13:33 +00:00

Owner

What

12 shell files disable SC1091 inline, because shellcheck does not follow the file that they source: scripts/release.sh:120 and 11 hook tests in hooks/tests/. The usage example at hooks/tests/lib-hook-harness.sh:84 tells each new hook test to copy the disable. CONTRIBUTING.md:319 says that linters flag real issues and that I fix the code.

How

Add a .shellcheckrc that lets shellcheck follow sourced files (external-sources=true and source-path=SCRIPTDIR). Then remove the 12 disables and update the usage example.

Acceptance

No SC1091 disable remains, and the usage example does not show one.
shellcheck passes on every file that had one.

## What 12 shell files disable SC1091 inline, because shellcheck does not follow the file that they source: `scripts/release.sh:120` and 11 hook tests in `hooks/tests/`. The usage example at `hooks/tests/lib-hook-harness.sh:84` tells each new hook test to copy the disable. `CONTRIBUTING.md:319` says that linters flag real issues and that I fix the code. ## How Add a `.shellcheckrc` that lets shellcheck follow sourced files (`external-sources=true` and `source-path=SCRIPTDIR`). Then remove the 12 disables and update the usage example. ## Acceptance - No SC1091 disable remains, and the usage example does not show one. - shellcheck passes on every file that had one.

hexajon added a new dependency

2026-10-14 19:15:29 +00:00

#766 epic: shellcheck passes on every shell script, with no inline disables

hexajon added a new dependency

2026-10-14 19:15:30 +00:00

#761 gate: lint every shell script with shellcheck, and fail when shellcheck is missing