tests: move the internal/service tests from fake forges to the harness #681

Open
opened 2026-09-29 23:05:35 +00:00 by hexajon · 0 comments
Owner

What to build

Every test in internal/service and the packages under it that starts a fake HTTP server for a forge, or replaces the forge client with a fake, runs against the harness instead, on both forges. A fault comes from the real servers: a large fixture, a stopped forge, a renamed repo, or the proxy's rate limit. A fake server for something that is not a forge stays.

Acceptance

  • No test in internal/service or a package under it starts a fake HTTP server for a forge or replaces the forge client with a fake.
  • The moved tests run against Forgejo and Gitea, and none is skipped.

Needs #677. Part of #674.

## What to build Every test in `internal/service` and the packages under it that starts a fake HTTP server for a forge, or replaces the forge client with a fake, runs against the harness instead, on both forges. A fault comes from the real servers: a large fixture, a stopped forge, a renamed repo, or the proxy's rate limit. A fake server for something that is not a forge stays. ## Acceptance - No test in `internal/service` or a package under it starts a fake HTTP server for a forge or replaces the forge client with a fake. - The moved tests run against Forgejo and Gitea, and none is skipped. Needs #677. Part of #674.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
sixfold-space/madtea#681
No description provided.