guard: a parity test fails when a write skips the guard #669

Closed
opened 2026-09-29 19:05:41 +00:00 by hexajon · 1 comment
Owner

ADR 0046 says that a forge client or a git writer built with no guard refuses every write, and that a parity test fails when production code builds one with no guard, or sends a write around the guarded functions.

Scope:

  • A test in internal/parity fails when production code builds a forge client or a git writer with no guard.
  • The same test fails when production code runs a git write command, or sends a forge write request, outside the guarded functions.

Acceptance:

  • A new production call that builds an unguarded client fails the test, and the failure names the file.
  • A raw git write outside internal/git fails the test.
  • The test passes on the tree after #659 and #660.

Depends on #659 and #660. Decision record: ADR 0046.

ADR 0046 says that a forge client or a git writer built with no guard refuses every write, and that a parity test fails when production code builds one with no guard, or sends a write around the guarded functions. Scope: - A test in `internal/parity` fails when production code builds a forge client or a git writer with no guard. - The same test fails when production code runs a git write command, or sends a forge write request, outside the guarded functions. Acceptance: - A new production call that builds an unguarded client fails the test, and the failure names the file. - A raw git write outside `internal/git` fails the test. - The test passes on the tree after #659 and #660. Depends on #659 and #660. Decision record: ADR 0046.
Author
Owner

The v0.20.0 breaking set is complete and green on main. The code landed across the v0.20.0 branches, the full local gate passes, and the forge suite is green on both forges at both pinned versions on current main (31693766). Closing as done.

The v0.20.0 breaking set is complete and green on main. The code landed across the v0.20.0 branches, the full local gate passes, and the forge suite is green on both forges at both pinned versions on current main (31693766). Closing as done.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
sixfold-space/madtea#669
No description provided.