sixfold-space/madtea

SHA256

Fork 0

adr check: verify every file reference in a record #658

New issue

Closed

opened 2026-09-29 16:39:21 +00:00 by hexajon · 2 comments

hexajon commented

2026-09-29 16:39:21 +00:00

Owner

What to build

adr check reads each reference to a file in a record, as a link or a backticked path, the way ADR 0037 defines:

A plain path names a file in this repo. It must exist in the committed tree, not only on disk.
A full URL names a file in another repo. The check reads it through the forge, and skips it when the forge checks are off.
A path that starts with ~/ or / is a file on a user's machine, and the check skips it.
A reference that holds a placeholder or a glob (NNNN, *, <name>, {...}) is skipped.
A line number after a path fails.

A Markdown link resolves from the record's own folder. A backticked path resolves from the repo root.

Acceptance

Tests against the live forge API and a test repo: a plain path to a deleted file fails; an untracked file fails; a full URL to a missing file fails; a ~/ path, a placeholder, and a glob pass unchecked; a path with a line number fails; a link and a backticked path each resolve from their own base.

This change can fail an existing tree, so it ships in the one breaking release.

## What to build `adr check` reads each reference to a file in a record, as a link or a backticked path, the way ADR 0037 defines: - A plain path names a file in this repo. It must exist in the committed tree, not only on disk. - A full URL names a file in another repo. The check reads it through the forge, and skips it when the forge checks are off. - A path that starts with `~/` or `/` is a file on a user's machine, and the check skips it. - A reference that holds a placeholder or a glob (`NNNN`, `*`, `<name>`, `{...}`) is skipped. - A line number after a path fails. A Markdown link resolves from the record's own folder. A backticked path resolves from the repo root. ## Acceptance Tests against the live forge API and a test repo: a plain path to a deleted file fails; an untracked file fails; a full URL to a missing file fails; a `~/` path, a placeholder, and a glob pass unchecked; a path with a line number fails; a link and a backticked path each resolve from their own base. This change can fail an existing tree, so it ships in the one breaking release.

hexajon referenced this issue

2026-09-29 18:28:31 +00:00

docs: link records instead of restating them, and gate every link to a record #664

hexajon referenced this issue

2026-09-29 19:02:30 +00:00

Epic: consolidate the decision records #646

hexajon referenced this issue

2026-09-29 19:31:31 +00:00

epic: v0.20.0 - breaking: clearer ADR tooling and the write guard on every surface #675

hexajon added a new dependency

2026-09-29 19:34:25 +00:00

#675 epic: v0.20.0 - breaking: clearer ADR tooling and the write guard on every surface

hexajon added a new dependency

2026-09-29 19:36:03 +00:00

#674 epic: run forge tests against throwaway Forgejo and Gitea servers behind a real proxy

hexajon referenced this issue

2026-10-16 00:17:51 +00:00

feat(adr)!: #658 adr check verifies every file reference in a record #782

hexajon referenced this issue from a commit

2026-10-16 00:17:52 +00:00

feat(adr): verify every file reference in a record

hexajon referenced this issue

2026-10-17 16:48:15 +00:00

bug(forge-test): the adr live forge test fails under the push-model runner, which ships no .git #795

hexajon commented

2026-10-17 16:48:55 +00:00

Author

Owner

The code for this landed on main, and the unit and fake-forge tests pass. The adr forge-tagged test package does not run green in the throwaway-forge VM yet: the live forge test cannot resolve a forge checkout, because the committed runner ships the tree with git archive and no .git. Tracked in #795. Keeping this open until the live forge run is green.

The code for this landed on main, and the unit and fake-forge tests pass. The adr forge-tagged test package does not run green in the throwaway-forge VM yet: the live forge test cannot resolve a forge checkout, because the committed runner ships the tree with `git archive` and no `.git`. Tracked in #795. Keeping this open until the live forge run is green.

hexajon added a new dependency

2026-10-18 03:00:09 +00:00

#795 bug(forge-test): the adr live forge test fails under the push-model runner, which ships no .git

hexajon commented

2026-10-18 05:23:09 +00:00

Author

Owner

The v0.20.0 breaking set is complete and green on main. The code landed across the v0.20.0 branches, the full local gate passes, and the forge suite is green on both forges at both pinned versions on current main (31693766). Closing as done.

hexajon removed a dependency

2026-10-18 05:24:39 +00:00

#674 epic: run forge tests against throwaway Forgejo and Gitea servers behind a real proxy

hexajon closed this issue

2026-10-18 05:25:18 +00:00