Apply the gopls quick fixes on main #631

New issue

Closed

opened 2026-09-24 19:35:55 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-24 19:35:55 +00:00

Owner

What

gopls reports findings on main that have quick fixes: tagged switches, fmt.Fprintf in place of WriteString(fmt.Sprintf(...)), split WriteString concatenations, and unused parameters. The commit "style: apply gopls quick fixes" applies them across 15 files.

This work merges before #624. The gopls gate leg in #624 fails on main while these findings are open.

Known problems in the commit

internal/service/workflow/finish_result.go: the failResult doc comment still describes the err parameter that the commit removes.
internal/mcp/tools_auth.go: the commit also changes a user-visible string. The dash in "unverified - no server check performed" changes from an em-dash to a hyphen. That change is not a gopls quick fix.

Acceptance

The quick fixes are on main.
The two problems above are resolved before the merge.
./scripts/gate.sh passes.

## What gopls reports findings on main that have quick fixes: tagged switches, `fmt.Fprintf` in place of `WriteString(fmt.Sprintf(...))`, split `WriteString` concatenations, and unused parameters. The commit "style: apply gopls quick fixes" applies them across 15 files. This work merges before #624. The gopls gate leg in #624 fails on main while these findings are open. ## Known problems in the commit - `internal/service/workflow/finish_result.go`: the `failResult` doc comment still describes the `err` parameter that the commit removes. - `internal/mcp/tools_auth.go`: the commit also changes a user-visible string. The dash in "unverified - no server check performed" changes from an em-dash to a hyphen. That change is not a gopls quick fix. ## Acceptance - The quick fixes are on main. - The two problems above are resolved before the merge. - `./scripts/gate.sh` passes.

hexajon added the

testing

label

2026-09-24 19:35:55 +00:00

hexajon added a new dependency

2026-09-24 19:36:01 +00:00

#624 gate: fail on every gopls diagnostic

hexajon referenced this issue

2026-09-24 19:36:49 +00:00

gate: fail on every gopls diagnostic #624

hexajon referenced this issue

2026-09-24 19:58:36 +00:00