git: 141 call sites use git config operation-mode flags, deprecated since git 2.46.0 #541
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Depends on
#536 git: raise the minimum version to 2.47.3 and publish the tested matrix
sixfold-space/madtea
Reference
sixfold-space/madtea#541
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
git 2.46.0 deprecated the
git configoperation-mode options in favour of subcommands:madtea uses the deprecated form in 141 places:
--get--unset--list--get-regexpThe subcommand form is used nowhere.
Why this was not actionable before, and is now
The replacement subcommands arrived in 2.46.0. While the declared floor was 2.38.0 the migration was impossible:
git config getdoes not exist at that floor, so the deprecated form was the only option that worked across the supported range.Raising the floor to 2.47.3 (#536) removes that bind. Both forms exist at and above the new floor, so the migration becomes possible for the first time.
Scope note
This is a deprecation, not a breakage. The old form still works, including on current git. There is no removal date, and git is conservative about removals. So this is not urgent, and the argument for doing it is that 141 call sites is a large surface to migrate under time pressure later, and the window opened as a side effect of #536.
Checked and clear
Two other deprecations in the same range do not affect madtea:
--headsonls-remoteandshow-ref, deprecated in 2.46.0 in favour of--branches. Not used.--keep-redundant-commits, soft-deprecated in 2.45.0. Not used.Acceptance
git configoperation-mode flags remain in non-test code.--porcelain.Depends on #536, which raises the floor to a version where the replacement exists.