ci(drift): run the drift checks on demand, and report at the start of the day #532
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#532
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #525 / PR #531.
What happens
drift.ymlhas three triggers:pull_request,pushto main, and one cron at17 4 * * *UTC. Two of its jobs,govulncheckand the newgit-matrix, are gatedif: github.event_name == 'schedule', so they run on that cron and nowhere else.Two problems follow.
Neither cron-only job can be run on demand. There is no
workflow_dispatchtrigger. Sogit-matrixshipped without ever executing, and its first run is unattended. It is also the run that first mountsmadtea-gitcache, a volume that has never been mounted. A mistake in the mount, the source build, or the signature check fails with nobody watching.The cron reports at the wrong end of the day.
17 4 * * *UTC is 22:17 in the maintainer's timezone, so a red drift result lands late at night and is read the next morning at the earliest.Ask
workflow_dispatchtrigger todrift.yml, and letgit-matrixrun on it as well as onschedule.0 13 * * *UTC, which is 07:00 local in summer and 06:00 in winter. Actions cron is UTC only, so the local time shifts by an hour across a daylight-saving change. Record that in the comment rather than leaving the reader to work it out.Notes
forgejo-smokeis gated onvars.RUN_FORGEJO_SMOKE == 'true' && github.event_name != 'pull_request'. Aworkflow_dispatchevent satisfies the second clause, so check the first before widening the trigger. The repository currently defines no Actions variables, so that job stays skipped.workflow_dispatchneeds write access on the repository, so it is a trusted event. The cache-mount expression already keys on!= 'pull_request'and treats it as trusted, which is correct.Acceptance
git-matrixcan be started by hand from the Actions tab.