docs(contributing): state that new functionality ships with tests #502

New issue

Closed

opened 2026-09-15 21:08:03 +00:00 by hexajon · 0 comments

hexajon commented

2026-09-15 21:08:03 +00:00

Owner

What happens

New features ship with tests in practice. The last eight feat commits all add or change tests. CONTRIBUTING.md does not say so. Its Testing section bans t.Skip() and //nolint, and the "Pull Request Guidelines" require a green gate, but no line says a change must add tests for new behaviour. The only written test step is in docs/contributing/adding-commands.md (a manifest sanity test).

This is also the open item for the OpenSSF Best Practices criterion tests_documented_added.

Ask

Add one line under "Pull Request Guidelines": new or changed behaviour comes with tests in the automated suite.

Acceptance

CONTRIBUTING.md states the rule.

## What happens New features ship with tests in practice. The last eight `feat` commits all add or change tests. `CONTRIBUTING.md` does not say so. Its Testing section bans `t.Skip()` and `//nolint`, and the "Pull Request Guidelines" require a green gate, but no line says a change must add tests for new behaviour. The only written test step is in `docs/contributing/adding-commands.md` (a manifest sanity test). This is also the open item for the OpenSSF Best Practices criterion `tests_documented_added`. ## Ask Add one line under "Pull Request Guidelines": new or changed behaviour comes with tests in the automated suite. ## Acceptance - `CONTRIBUTING.md` states the rule.

hexajon added the

documentation

label

2026-09-15 21:08:03 +00:00

hexajon referenced this issue from a pull request that will close it,

2026-10-21 15:48:38 +00:00

docs: require tests for new or changed behavior in CONTRIBUTING.md #862

hexajon referenced this issue from a commit

2026-10-21 15:48:41 +00:00

docs: require tests for new or changed behavior in CONTRIBUTING.md

hexajon closed this issue

2026-10-21 15:48:46 +00:00