auth login: origin-mismatch UI does not fire for env-only (MADTEA_URL) forge config #379
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea#379
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The origin-aware interactive
auth login(branchfix/auth-login-origin-aware) compares the configured forge against the repo origin and warns on a mismatch. The configured forge comes fromconfig.DetectURL, which reads the mergedmadtea.urlgit config and the origin remote, but NOT theMADTEA_URLenvironment variable.So a forge configured purely via
MADTEA_URLyieldsconfiguredForge="", andplanLoginforcesmismatch=false. A genuine env-forge-vs-origin mismatch is silently not surfaced.Not a regression (the prior flow had no mismatch detection at all). Fix: have the mismatch detection also treat
MADTEA_URLas a configured-forge source (resolve the configured forge through the same precedence the resolver uses), so env-configured users get the mismatch warning too.