feat(ssh): finish and push legs over SSH in ssh modes; API legs gate on the token #346
No reviewers
Labels
No labels
breaking
bug
documentation
enhancement
epic
good first issue
help wanted
refactoring
resolution/duplicate
resolution/invalid
resolution/wontfix
security
severity/critical
severity/high
severity/low
severity/medium
status/abandoned
status/blocked
status/needs-decision
status/needs-info
status/needs-verification
testing
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sixfold-space/madtea!346
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-294-ssh-finish-push-legs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
In ssh and ssh-only modes every git-transport leg finish drives - the push inside finish, madt_push, and the authenticated pull/fetch/status paths - runs over the SSH remote form with no GIT_ASKPASS and no token on the git wire; setupSSHCmd overrides the remote URL and builds the command from os.Environ() only. finish's API legs gate on the shared ssh-only chokepoint: in ssh-only the create-PR step degrades with the typed error naming the pushed branch, riding the existing ledger; in token+ssh the gate is a no-op and finish runs end to end. Branch-detected issue classification degrades to plain refs in ssh-only instead of hard-failing before the push, so the branch is never stranded. A leftover token in ssh-only never reaches the git wire or the API; https and unset modes pinned unchanged.
Closes #294.
Closes #294