Reword decision attributions in ADRs, source comments, and the release-gate message to the public voice #256

Closed
opened 2026-07-19 00:33:58 +00:00 by hexajon · 0 comments
hexajon commented 2026-07-19 00:33:58 +00:00 (Migrated from codeberg.org)

Pre-release sweep: several files attribute decisions to an informal personal name (and in one spot a second, inconsistent handle) in third-person narration. Public text should state decisions as plain fact in first person, keeping the date where it carries provenance, e.g. "Decided 2026-07-03: ...".

Locations:

  • Runtime-visible (most exposed): scripts/release-gate.sh:121 - the gate refusal message tells the reader to escalate to a person by first name. Anyone hitting the release gate sees this. Should read "surface that on the issue tracker" or similar.
  • Source comments: internal/service/workflow/merge.go:62-63, internal/service/prune/run.go:164, internal/config/oauth_mint.go:23, internal/cmd/setup/prompt.go:198, internal/cmd/setup/save.go:62
  • ADRs: docs/adr/0006 (L24), 0013 (L70), 0016 (L219), 0021 (L155,160), 0024 (L34), 0025 (L131), 0027 (L3), 0028 (L3)
  • docs/adr/0008-operation-registry-source-of-record.md:152 uses a different informal handle for the same person
  • The agent-guidance file at the repo root, L17

The test fixture at hooks/tests/check-git-secrets.test.sh:149 uses the name as an arbitrary git user.name value - harmless, but may as well switch to a placeholder in the same pass.

Acceptance: grep for both informal handles over tracked files comes back empty; the gate script message reads neutrally; ADR decision lines carry dates without personal attribution.

Pre-release sweep: several files attribute decisions to an informal personal name (and in one spot a second, inconsistent handle) in third-person narration. Public text should state decisions as plain fact in first person, keeping the date where it carries provenance, e.g. "Decided 2026-07-03: ...". Locations: - **Runtime-visible (most exposed):** `scripts/release-gate.sh:121` - the gate refusal message tells the reader to escalate to a person by first name. Anyone hitting the release gate sees this. Should read "surface that on the issue tracker" or similar. - Source comments: `internal/service/workflow/merge.go:62-63`, `internal/service/prune/run.go:164`, `internal/config/oauth_mint.go:23`, `internal/cmd/setup/prompt.go:198`, `internal/cmd/setup/save.go:62` - ADRs: `docs/adr/0006` (L24), `0013` (L70), `0016` (L219), `0021` (L155,160), `0024` (L34), `0025` (L131), `0027` (L3), `0028` (L3) - `docs/adr/0008-operation-registry-source-of-record.md:152` uses a different informal handle for the same person - The agent-guidance file at the repo root, L17 The test fixture at `hooks/tests/check-git-secrets.test.sh:149` uses the name as an arbitrary git user.name value - harmless, but may as well switch to a placeholder in the same pass. Acceptance: grep for both informal handles over tracked files comes back empty; the gate script message reads neutrally; ADR decision lines carry dates without personal attribution.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sixfold-space/madtea#256
No description provided.